feat: Add infra for cleaning up providers when deleted #2871
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Ihor Panasiuk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
dosubot
bot
added
size:M
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 8134198 | Triggered | Generic High Entropy Secret | 4c9b0e6 | keep-ui/app/frigade-provider.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
talboren
deleted the
feature/392-add-infra-for-cleaning-up-providers-when-deleted
branch
|
🔥 Fantastic work @skynetigor! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
Closes #392
📑 Description
Added base functionality for cleaning up provider leftovers when it's deleted in Keep.
Now base provider has clean_up function that each inheritor can override in order to implement its own clean up logic. The function is called during provider deletion.
Add cleaning up webhooks for PagerDuty provider.
✅ Checks
ℹ Additional Information